kubernetes-sigs / kubernetes-sigs/multicluster-runtime
Realign `pkg/builder/forked_webhook.go` with upstream
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 311
- Forks
- 54
- Avg merge
- 5d 16h
- Merged PRs (30d)
- 4
Description
This is a todo coming out of https://github.com/kubernetes-sigs/multicluster-runtime/pull/124#discussion_r2728797884. Looks like some types for admission were deprecated in controller-runtime upstream, we should re-evaluate the forked webhook code and make sure it aligns with upstream.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with pkg/builder/forked_webhook.go and the linked discussion in pull request 124; compare its admission types with the current controller-runtime upstream definitions. Re-evaluate the deprecated types and update the fork so it aligns with upstream. Done means the forked webhook code no longer diverges from the relevant upstream approach.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- api, backend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100