kubernetes-sigs / kubernetes-sigs/controller-tools

Warn about things that we strongly recommend avoiding

Open
#434 8 comments 1 reaction 1 assignee Claimed by @ksaritek View on GitHub
good first issue help wanted kind/feature lifecycle/frozen priority/important-soon
Dominant language
Go
Stars
868
Forks
482
Avg merge
1d 11h
Merged PRs (30d)
8

Description

#317 introduces support for a pattern we generally don't recommend: pointers as map values. This is mainly for a few legacy use cases that folks want to support, but I think we generally want to warn people that this isn't a pattern that we/the kube API conventions generally suggest/support.

We probably want something that looks a lot like our error reporting system, but works adds a "non-fatal" warning instead of a semi-fatal error. I'd expect something like:

```go
pkg.AddWarning(loader.ErrorFromNode(...))
```

and then print out warnings at the end.

#317 is the only case I know of off the top of my head, but having this infra would prob be useful in the future.

/help
/good-first-issue
/kind feature
/priority important-soon

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.