kubernetes-sigs / kubernetes-sigs/controller-runtime
Object doesn't get updated after Client.Delete(object)
Open
Nobody has claimed this yet.
kind/bug
lifecycle/frozen
- Dominant language
- Go
- Stars
- 3k
- Forks
- 1.3k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 14
Description
fakeClient.Delete(obj) doesn't update deletionTimestamp of the obj passed to the function. The bug is in fakeClient.deleteObject, since it gets a new object and updates the new object without rewriting the original object.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pkg/client/fake/client.go around lines 1085-1095 and inspect fakeClient.deleteObject, especially how the object passed to Delete relates to the newly obtained object. Check the existing fake-client tests, then verify that deleting through fakeClient.Delete(obj) updates the passed object's deletionTimestamp as well as the stored object.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- testing
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 48/100