kubernetes-sigs / kubernetes-sigs/controller-runtime
Manager should expose http.Handlers to allow extension by users
@alexanderstephan is already working on this.
Since Mar 18, 2023.
- Dominant language
- Go
- Stars
- 3k
- Forks
- 1.3k
- Avg merge
- 2d 5h
- Merged PRs (30d)
- 14
Description
Based on a conversation we had on the community call on the 18th June 2020:
There are several http.Handlers set up by the manager that are currently only accessible if served by the manager (metrics and webhooks). If the manager exposed these handlers once constructed this would allow extension by authors to customise how these endpoints are served.
For example, an author could use their own server and serve TLS connections directly instead of using the HTTP only server that is currently implemented with controller-runtime
Or the user could add some HTTP middleware to ensure that all requests to the endpoints are logged in a particular way or authenticated and authorized before serving the content
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.