kubernetes-sigs / kubernetes-sigs/cluster-api
Ensure we don't have unexpected double rollouts in ClusterClass e2e tests
- Dominant language
- Go
- Stars
- 4.3k
- Forks
- 1.6k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 113
Description
Context:
* An unexpected double rollout in the ClusterClass context e.g. means that when we apply changes to Cluster.spec.topology (e.g. setting etcdImageTag and upgrading the version) those changes are rolled out with a single rollout.
* A double rollout would be:
* The topology controller propagates the etcdImageTag to KCP
* Then waits until KCP is stable again
* The topology controller then bumps the version in KCP
We found an unexpected double rollout when triaging: https://github.com/kubernetes-sigs/cluster-api/issues/7833 (essentially what is described under context).
In this issue we should:
* analyze in which test cases double rollouts could occur
* find a way to validate that they didn't occur
* also consider how this works with other providers where double rollouts might be expected
* It can depend on the cluster-template. So maybe the validation must be opt-in / opt-out
At this point the issue requires a bit more research and an idea how to implement the validation before it is actionable.
/area topology
/area testing
/kind feature
Contributor guide
Assessment
This issue has not been assessed yet.