kubernetes-sigs / kubernetes-sigs/cluster-api

Changing machinedeployment.spec.template.metadata.annotations doesn't result in rotation

Open
#13,836 3 comments 0 reactions 0 assignees View on GitHub
kind/support needs-priority needs-triage
Dominant language
Go
Stars
4.3k
Forks
1.6k
Avg merge
1d 3h
Merged PRs (30d)
113

Description

### What steps did you take and what happened?

I changed the machinedeployment.spec.template.metadata.annotations with the CA secret hash.

### What did you expect to happen?

I expected the machines to rotate to load the new CA.

### Cluster API version

1.13.2

### Kubernetes version

1.34.1

### Anything else you would like to add?

I understand that labels are being dropped for rotation, but as normal k8s deployments rotate on annotation change, I assumed this would work as well.

I assume the same thing applies to machinePools. I know I can use rollout.after for machinedeployment, but what to use for machinePools?

Another solution would be that CAPI would rotate machines when the CA changes.

### Label(s) to be applied

/kind bug
One or more /area label. See https://github.com/kubernetes-sigs/cluster-api/labels?q=area for the list of labels.

Contributor guide

Open the contributing guide

Research direction

Start by tracing how MachineDeployment handles changes to spec.template.metadata.annotations and compare that behavior with rollout.after and MachinePool behavior. Check the relevant reconciliation and rollout tests, if present, and define done as a documented, tested answer for whether annotation changes trigger rotation and what equivalent MachinePool mechanism exists.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.