kubernetes-sigs / kubernetes-sigs/cluster-api
Add machineNaming support to MachineDeploymentClass and MachineDeploymentTopology
- Dominant language
- Go
- Stars
- 4.3k
- Forks
- 1.6k
- Avg merge
- 1d 3h
- Merged PRs (30d)
- 113
Description
### What would you like to be added (User Story)?
`machineNaming` field from `MachineDeploymentSpec` should be exposed in `MachineDeploymentClass` and `MachineDeploymentTopology` so topology-managed clusters can customize Machine names within MachineDeployments.
### Detailed Description
`machineNaming` on `MachineDeploymentSpec` allows customizing Machine names, but the topology controller doesn't propagate it. There's no way to set it through ClusterClass or Cluster topology.
This means topology-managed MachineDeployments always produce Machine names like `cluster-worker-8fh2k-xn4wp` (MachineSet name + random suffix). There's no way to simplify this to e.g. `cluster-worker-xn4wp`.
Proposal: add `machineNaming` to `MachineDeploymentClass` with optional override in `MachineDeploymentTopology`, same as how naming already works for the MachineDeployment object name.
References:
- MachineNamingStrategy on MachineDeploymentSpec: #9340
- naming / machineNaming rename: #12524
- API consistency umbrella: #12497
### Anything else you would like to add?
Same gap applies to `MachinePoolClass` / `MachinePoolTopology`.
### Label(s) to be applied
/kind feature
/area clusterclass
/area machinedeployment
/area api
Contributor guide
Assessment
This issue has not been assessed yet.