kubernetes-sigs / kubernetes-sigs/cli-utils
Chore: refactor Filters to take TaskContext
Open
lifecycle/frozen
- Dominant language
- Go
- Stars
- 178
- Forks
- 85
- PR merge metrics
- No merged PRs in 30d
Description
The new DependencyFilter takes the context in its struct and some of the other filters need the Context to support cancellation of HTTP calls. We should refactor the Filter API to take the context in the Filter method interface.
Related: https://github.com/kubernetes-sigs/cli-utils/issues/440
Contributor guide
Research direction
Start by reading the Filter method interface and the DependencyFilter implementation, then review related issue #440 for the intended API change. Done means the Filter API and affected filters consistently accept context and support cancellation of HTTP calls.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go
- Domain
- cli
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100