kubernetes-client / kubernetes-client/javascript

Timestamps have wrong type

Open
#487 25 comments 3 reactions 0 assignees View on GitHub
lifecycle/frozen
Dominant language
TypeScript
Stars
2.3k
Forks
568
Avg merge
17h 57m
Merged PRs (30d)
41

Description

The timestamps have incorrect typescript types.
For example
https://github.com/kubernetes-client/javascript/blob/master/src/gen/model/v1ObjectMeta.ts#L32

creationTimestamp is of type Date | undefined, but the documentation says it's an RFC3339 formatted date aka a string.

Since this is generated code I'm not sure of where to fix this. Either the type has to change to string | undefined, or the string has to be parsed and passed on as a date object.

Contributor guide

Open the contributing guide

Research direction

Start with src/gen/model/v1ObjectMeta.ts around the creationTimestamp definition and compare its TypeScript type with the RFC3339 string described in the issue. Trace how this generated model is produced or consumed to determine whether the type or runtime representation is inconsistent. Done means the timestamp type and its actual representation agree with the documentation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
api
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.