kubermatic / kubermatic/operating-system-manager

Kubelet Feature Gates from MD annotations are not going through

Open
#534 7 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
53
Forks
43
Avg merge
1d 2h
Merged PRs (30d)
15

Description

Hi
I have got a MachineDeployment object with metadata like this:
```
metadata:
annotations:
v1.kubelet-featuregates.machine-controller.kubermatic.io/DRAConsumableCapacity: "true"
v1.kubelet-featuregates.machine-controller.kubermatic.io/DRADeviceTaints: "true"
v1.kubelet-featuregates.machine-controller.kubermatic.io/DRAExtendedResource: "true"
v1.kubelet-featuregates.machine-controller.kubermatic.io/DRAPrioritizedList: "true"
v1.kubelet-featuregates.machine-controller.kubermatic.io/DynamicResourceAllocation: "true"
v1.kubelet-featuregates.machine-controller.kubermatic.io/ResourceHealthStatus: "true"
```

which is taken from Machine-Controller's code here https://github.com/kubermatic/machine-controller/blob/main/sdk/apis/cluster/common/consts.go#L181 but I cannot find any place where it would be used around here ? https://github.com/kubermatic/operating-system-manager/blob/main/pkg/controllers/osc/resources/operating_system_config.go#L465

am I overlooking something? Because the output kubeletConfig does NOT have these featuregates enabled or even templated in the output OSC.

Thanks
Ashley

Contributor guide

Open the contributing guide

Research direction

Start in pkg/controllers/osc/resources/operating_system_config.go around the referenced line and trace how MachineDeployment annotations reach the generated OSC kubeletConfig. Compare that path with the feature-gate annotation constants in machine-controller's sdk/apis/cluster/common/consts.go. Reproduce the supplied annotations and consider the issue done when the resulting OSC contains the expected kubelet feature gates.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
infrastructure
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.