kubermatic / kubermatic/machine-controller

Allow to disable forceful deletion of machines

Open
#2,069 0 comments 0 reactions 1 assignee Claimed by @ahmadhamzh View on GitHub
customer-request kind/feature
Dominant language
Go
Stars
326
Forks
138
Avg merge
2d 46m
Merged PRs (30d)
12

Description

### Description of the feature you would like to add / User story

As a KKP administrator / KKP user cluster owner
I would like to have the ability to completely disable the machine-controllers node eviction timeout (`--skip-eviction-after`)
in order to have full (manual) control after which time a node / machine is deleted

### Solution details

- machine-controller provides an option to completely disable the forceful deletion of machines (e.g. Cluster API allows you to set [`Machine.spec.nodeDrainTimeout` to 0](https://github.com/kubernetes-sigs/cluster-api/blob/v1.14.0/docs/book/src/tasks/automated-machine-management/machine_deletions.md?plain=1#L17) to specify that the node can be drained without any time limitations)

### Alternative approaches

- set `--skip-eviction-after` to the highest possible value

### Use cases

Right now, the machine-controller will eventually forcefully delete a machine, and the associated node after the configured node drain timeout (`--skip-eviction-after`) expired, and there is no way to disable this behavior. However, there may be situations in which the cluster administrator wants to have full control over the machine deletion process to prevent any involuntary disruptions to workloads running on that machine / node.

### Additional information

/label customer-request
Internal reference: 9415

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.