kubermatic / kubermatic/machine-controller

KubeVirt provider should honor the explicitly selected instancetype kind

Open
#2,065 0 comments 0 reactions 1 assignee Claimed by @adoi View on GitHub
kind/bug
Dominant language
Go
Stars
326
Forks
138
Avg merge
2d 46m
Merged PRs (30d)
12

Description

The KubeVirt provider's `defaultVMInstanceType` function currently ignores the `Kind` supplied in `InstancetypeMatcher` and discovers the resource by name.

The lookup order is currently: Namespaced `VirtualMachineInstancetype` and then Cluster scoped `VirtualMachineClusterInstancetype`. This happens even when the provider specification explicitly contains:

```yaml
instancetype:
name: h200-worker
kind: VirtualMachineClusterInstancetype
```

If both a namespaced VirtualMachineInstancetype/h200-worker and a cluster VirtualMachineClusterInstancetype/h200-worker exist, machine-controller selects the namespaced object despite the explicitly submitted cluster scoped kind

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.