kubermatic / kubermatic/machine-controller
Sensible defaulting for Azure VMs with security type TrustedLaunch
Nobody has claimed this yet.
- Dominant language
- Go
- Stars
- 326
- Forks
- 138
- Avg merge
- 2d 46m
- Merged PRs (30d)
- 12
Description
This is a follow-up ticket on https://github.com/kubermatic/machine-controller/issues/2013
The fix done via PR https://github.com/kubermatic/machine-controller/pull/2020 needs us to write additional values mandatorily
securityProfile:
securityType: TrustedLaunch
secureBootEnabled: true
vTpmEnabled: true
Can we make it easier by just specifying securityType: TrustedLaunch and then defaulting rest of the two params when securityType is TrustedLaunch?
Those sub params can continue to exist for someone who wants to override them manually.. but if user does not specify it, then they should be default to above values in case securityType is TrustedLaunch
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how Azure VM securityProfile values are handled, using issue 2013 and PR 2020 for context. Verify that specifying only securityType: TrustedLaunch supplies secureBootEnabled and vTpmEnabled, while explicitly provided subparameters remain effective.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- azure, go
- Domain
- cloud, infrastructure
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 58/100