kubereboot / kubereboot/kured

lock on a separate/safe object rather than DaemonSet

Open
#25 9 comments 1 reaction 0 assignees View on GitHub
enhancement FEATURE-v2 keep
Dominant language
Go
Stars
2.6k
Forks
233
PR merge metrics
No merged PRs in 30d

Description

Current locking approach requires the kured job to have the RBAC privilege to be able to update its own DaemonSet. This means a compromised kured job could redefine itself to (eg) elevate host access further(*).

Better (from an RBAC pov) would be to use a "harmless" resource type to store the lock annotation. A ConfigMap (empty/dedicated for this purpose) would be ideal.

(*) I acknowledge that kured also needs other scary privileges (patch nodes) in order to conduct a drain/uncordon, and these won't be improved by this suggestion. Small steps.

Contributor guide

Open the contributing guide

Research direction

The issue names no files, tests, or entry points. Start by tracing how kured currently stores its lock on the DaemonSet and which RBAC permissions support that operation. Evaluate a dedicated ConfigMap as the lock resource, with completion requiring the lock and RBAC behavior to work without updating the DaemonSet.

Written by the indexing model from the issue text.

Assessment

Tech stack
go, kubernetes
Domain
infrastructure, security
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.