kubeflow / kubeflow/trainer

Rename CertManagement.WebhookServiceName and CertManagement.WebhookSecretName config settings

Open
#3,327 6 comments 0 reactions 1 assignee Claimed by @tariq-hasan View on GitHub
Dominant language
Go
Stars
2.2k
Forks
1.1k
Avg merge
3d 22h
Merged PRs (30d)
39

Description

The CertManagement settings in the Configuration api currently refer to webhooks, but the cert is also used by the metrics server, and (once https://github.com/kubeflow/trainer/pull/3227 is merged) the train job status server.

It would be good to rename the config settings to avoid confusion.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.