Surface model signing submodule in kubeflow.hub
- Dominant language
- Python
- Stars
- 148
- Forks
- 262
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 1
Description
In order to support easy signing of model artifacts we should make model_registry.signing a first-class utility in kubeflow sdk. For this step, we should simply move the code to a submodule of the kubeflow sdk instead of model_registry.
This isn't building a new feature because it is already pulled in if a user does:
```sh
pip install 'kubeflow[hub]'
```
then in python:
```python
from model_registry.signing import Signer
signer = Signer()
signer.sign_model(model_dir)
signer.verify_model(model_dir)
signer.sign_image(image_uri)
signer.verify_image(image_uri)
```
## motivation
This `signing` submodule under `model_registry` is actually independent of the rest of model registry and could be used with any model registry solution.
## implementation
Moving `model_registry.signing` to `kubeflow.hub.signing` would allow signing to still be logically tied to Kubeflow Hub while surfacing it cleanly in kubeflow sdk so it is easy to use with any model registry.
Contributor guide
Assessment
This issue has not been assessed yet.