kubeflow / kubeflow/notebooks

JupyterLab WSK hidden in the default sample setup

Open
#1,386 4 comments 0 reactions 1 assignee Claimed by @thisis-Shitanshu View on GitHub
kind/bug priority/needs-triage
Dominant language
No language data
Stars
84
Forks
149
Avg merge
5d 15h
Merged PRs (30d)
29

Description

### Checks

- [x] I have searched the [existing issues](https://github.com/kubeflow/notebooks/issues).
- [x] My issue is related to one of the components in the [`kubeflow/notebooks`](https://github.com/kubeflow/notebooks) repository.

### Kubeflow Notebooks Version

v2.0.0-beta.1

### Kubeflow Platform

KCD

### Kubernetes Distribution

KinD

### Kubernetes Version

```shell
Client Version: v1.36.3
Kustomize Version: v5.8.1
Server Version: v1.35.
```

### Description

When deploying Kubeflow Workspaces version `v2.0.0-beta.1` by default the JupyterLab Workspace is hidden from the WS create flow:

Image

This is due to the filterRules that landed with #1357 and they way that our samples are set up:

https://github.com/kubeflow/notebooks/blob/18035691b8099f4bcdbb684c3d4b7ba047ab13c0/workspaces/controller/manifests/kustomize/samples/jupyterlab_v1beta1_workspacekind.yaml#L65-L76ry

It's quite nice to see the feature working, however I could see that this could confuse people that want to try out the beta release. Also we've been stressing that those are only example configurations, however the JupyterLab sample is our most comprehensive one (showcasing redirects etc.), so we should most likely make that visible by default.

### Relevant Logs

```shell

```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.