kubeflow / kubeflow/notebooks

Notebook Controller Leader Election

Open Beginner friendly
#104 7 comments 1 reaction 0 assignees View on GitHub
area/v1 help wanted kind/bug lifecycle/frozen
Dominant language
No language data
Stars
84
Forks
149
Avg merge
5d 15h
Merged PRs (30d)
29

Description

/kind bug

**What steps did you take and what happened:**
[A clear and concise description of what the bug is.]
When deploying notebook-controller via `v1.6.0-rc.0` the `manager` container of `notebook-controller` failed to start to due to missing permissions to `get,create,patch` `coordination.k8s.io` `leases` for the leader-election resource. I got past the issue by creating a patch in my manifests repo to add the leader-election permissions needed.

**What did you expect to happen:**
The leader-election role found [here](https://github.com/kubeflow/kubeflow/blob/master/components/notebook-controller/config/rbac/leader_election_role.yaml), should have the below config added to prevent notebook controller from failing to start if leader election gets enabled.

```
apiGroups:
- coordination.k8s.io
resources:
- leases
verbs:
- get
- list
- create
- update
- delete
- patch
- watch
```

**Anything else you would like to add:**
I think this issue came about updating the notebook-controller go version to `1.17` as this was not an issue before in kubeflow `v1.5.0`.

**Environment:**

- Kubeflow version: (version number can be found at the bottom left corner of the Kubeflow dashboard): `v.1.6.0-rc.0`
- Kubernetes platform: (e.g. `minikube`) eks
- Kubernetes version: (use `kubectl version`): 1.21

Contributor guide

Open the contributing guide

Research direction

Start with components/notebook-controller/config/rbac/leader_election_role.yaml and compare its rules with the leader-election permissions described in the issue. Render or apply the manifests in a Kubernetes environment, then verify that the notebook-controller manager starts successfully with leader election enabled and has the required lease permissions.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes
Domain
authorization, infrastructure
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
72/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.