kubeflow / kubeflow/mpi-operator
"cleanPodPolicy: All" does not clean up launcher pod
- Dominant language
- Go
- Stars
- 535
- Forks
- 238
- Avg merge
- 2d 3h
- Merged PRs (30d)
- 10
Description
In MPIJob spec.runPolicy.cleanPodPolicy, we can set "All" to clean up all pods after completion including the launcher pod. However, it seems it only cleans up worker pods, as you can see in this [code](https://github.com/kubeflow/mpi-operator/blob/master/pkg/controller/mpi_job_controller.go#L607-L615).
Using the official example [pi.yaml](https://github.com/kubeflow/mpi-operator/blob/master/examples/v2beta1/pi/pi.yaml), if you change "cleanPodPolicy: Running" to "cleanPodPolicy: All", you can reproduce the issue.
Contributor guide
Research direction
Start in pkg/controller/mpi_job_controller.go around lines 607-615, then reproduce the behavior with examples/v2beta1/pi/pi.yaml after changing cleanPodPolicy from Running to All. Trace the cleanup handling for worker and launcher pods. Done means cleanPodPolicy: All removes the launcher pod as well as the worker pods after completion.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- go, kubernetes
- Domain
- distributed-systems
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100