kubeflow / kubeflow/mcp-server

Question: Should run_container_training validate container image references before submission?

Open Beginner friendly
#260 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
44
Forks
54
Avg merge
2d 18h
Merged PRs (30d)
29

Description

## Description

The `run_container_training()` tool in `kubeflow_mcp/trainer/api/training.py` currently accepts the `image` argument and passes it directly to the Trainer SDK.

Empty or malformed image values may reach Kubernetes, where the failure appears later as an image-pull or container-start error. This makes the input problem difficult to identify before the job is submitted.

adding basic validation before the Trainer SDK call, such as:

- Rejecting empty or whitespace-only image values.
- Rejecting clearly malformed container image references.
- Returning a structured `VALIDATION_ERROR`.
- Ensuring the Kubernetes client is not called when validation fails.
Can i create issue and submit PR for this

Contributor guide

Open the contributing guide

Research direction

Start in kubeflow_mcp/trainer/api/training.py at run_container_training() and inspect the existing image handoff and error handling. Define the validation scope from the listed requirements, then verify that invalid values return VALIDATION_ERROR and that the Kubernetes client is not called when validation fails.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes, python
Domain
api, backend-api-design, machine-learning
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Active
Clarity
Mostly clear
Newbie friendliness
68/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.