kubeflow / kubeflow/dashboard

Add annotation to namespace from profile CRD

Open
#47 4 comments 1 reaction 0 assignees View on GitHub
lifecycle/frozen
Dominant language
TypeScript
Stars
19
Forks
68
Avg merge
2d 16h
Merged PRs (30d)
10

Description

/kind question

**Question:**
Hi, I want to add annotation to a namespace created by kubeflow Profiles. If I looked correctly its not possible, only annotations added to a namespace is the owner of the profile.

https://github.com/kubeflow/kubeflow/blob/b922fa1573e4f0d19548f5ea94dbe3f78826bfed/components/profile-controller/controllers/profile_controller.go#L129

So with:
```
apiVersion: kubeflow.org/v1beta1
kind: Profile
metadata:
name: test
spec:
owner:
kind: User
name: user@test.com
```

Namespace created is:
```
>kubectl describe namespace test
Name: test
Labels: app.kubernetes.io/part-of=kubeflow-profile
istio-injection=enabled
katib.kubeflow.org/metrics-collector-injection=enabled
kubernetes.io/metadata.name=test
pipelines.kubeflow.org/enabled=true
serving.kubeflow.org/inferenceservice=enabled
Annotations: owner: user@test.com
```

Motivation:

We want to have several nodes in cluster dedicated to production workload and with annotation on namespace
```
> kubectl describe namespace production
Name: production
Annotations:
scheduler.alpha.kubernetes.io/node-selector: workset=production
```
we are able to separete production and research experimentation workloads.

Am I missing something or its a thing for contribution?

Contributor guide

Open the contributing guide

Research direction

Start with the referenced components/profile-controller/controllers/profile_controller.go entry point and trace how a Profile is reconciled into a namespace. Check the Profile CRD fields and any nearby reconciliation tests, if present; done should mean a Profile can express the requested namespace annotation while preserving the existing owner annotation.

Written by the indexing model from the issue text.

Assessment

Tech stack
kubernetes
Domain
infrastructure
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.