ktorio / ktorio/ktor

DefaultConversionService issue with enums

Open
#399 4 comments 1 reaction 0 assignees View on GitHub
design ux
Dominant language
Kotlin
Stars
14.5k
Forks
1.3k
Avg merge
2d 13h
Merged PRs (30d)
49

Description

I noticed `DefaultConversionService#convert` uses `Enum#name` and not `Enum#toString`.
The issue with this in locations comes with how most conventions have enum constants be uppercased, while paths are usually lowercased.
Therefore, using `#toString` would let the developer decide for themselves.

Contributor guide

Open the contributing guide

Research direction

Locate DefaultConversionService#convert and inspect how enum values are converted. Review the surrounding conversion behavior and existing tests before deciding how the requested enum string representation should work. Done means enum conversion supports the representation needed for lowercased paths and locations.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
backend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.