kthcloud / kthcloud/go-deploy

Disabled deployments remain disabled when replicas are updated to >= 1

Open
#683 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
3
Forks
1
PR merge metrics
No merged PRs in 30d

Description

Describe the bug
When re-enabling disabled deployments (deployments with 0 replicas) by setting replicas back to >= 1 they remain disabled.

To Reproduce
Create a deployment with zero replicas ( or create one with x replicas and then update it to 0).

curl -X POST https://api.cloud.cbh.kth.se/deploy/v2/deployments \
-d'{
  "name": "randombugtestname",
  "cpuCores": 0.1,
  "ram": 0.1,
  "replicas": 0,
  "envs": null,
  "volumes": null,
  "initCommands": null,
  "args": null,
  "visibility": "private",
  "neverStale": false,
  "private": false,
  "image": "phillezi/litelogger:latest",
  "healthCheckPath": null,
  "zone": null
}' \
-H "Content-Type: application/json" \
-H "Authorization: Bearer <keycloak-jwt>" # or use X-Api header with a api token

(can be done on the swagger ui or through cloud.cbh.kth.se instead of curl too.)

Then re-enable it:

curl -X POST https://api.cloud.cbh.kth.se/deploy/v2/deployments/<deployment-id> \
-d'{
  "replicas": 1
}' \
-H "Content-Type: application/json" \
-H "Authorization: Bearer <keycloak-jwt>" # or use X-Api header with a api token

(can be done on the swagger ui or through cloud.cbh.kth.se instead of curl too.)

It remains disabled, despite having 1 replica. It gets updated if i update another spec like the cores or ram.

Expected behavior
The deployment should be re-enabled when replicas are updated to > 0.

Workaround fix
If you update cores or ram after changing the replicas back to > 0 it should re-enable it.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the deployment update endpoint, POST /deploy/v2/deployments/, and trace how a replicas change is handled when the current value is zero. Reproduce the issue through the API or Swagger UI; done means changing replicas from 0 to 1 re-enables the deployment without changing cores or RAM.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
api
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
55/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.