kriasoft / kriasoft/react-firebase-starter

Cannot read property 'tap' of undefined with Typescript added

Open
#576 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
4.5k
Forks
752
PR merge metrics
No merged PRs in 30d

Description

### Typescript packages added
```
typescript@^3.8.3
"@types/jest": "^25.1.4",
"@types/node": "^13.9.8",
"@types/react": "^16.9.29",
"@types/react-dom": "^16.9.5"
```

### Findings
1. `yarn build` runs successfully and builds with the typescript packages
2. After removing the typescript dependencies, the dev server runs fine.

### Problem
Running `yarn start` with the typescript dependencies,
I see the following error with minimal clues on where the problem is,
```
yarn run v1.22.4
$ yarn relay
$ relay-compiler --src ./src --schema ./schema.graphql
HINT: pass --watch to keep watching for changes.

Writing js
Unchanged: 29 files
$ react-app start
Cannot read property 'tap' of undefined
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
```

My `tsconfig.json` is the default generated one and I've been trying to dig into the configs but no luck yet,
```
{
"compilerOptions": {
"target": "es5",
"lib": [
"dom",
"dom.iterable",
"esnext"
],
"allowJs": true,
"skipLibCheck": true,
"esModuleInterop": true,
"allowSyntheticDefaultImports": true,
"strict": true,
"forceConsistentCasingInFileNames": true,
"module": "esnext",
"moduleResolution": "node",
"resolveJsonModule": true,
"isolatedModules": true,
"noEmit": true,
"jsx": "preserve"
},
"include": [
"src"
]
}
```
Anyone care to shed some light? Thanks.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by reproducing the failure with `yarn start` and comparing the dependency sets described in the issue. Inspect `tsconfig.json` and the `yarn relay`/`react-app start` entry points to locate the source of the undefined `tap` access; done means identifying and documenting a fix that lets the development server start with the TypeScript packages installed.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, react, typescript
Domain
build-system, tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.