kriasoft / kriasoft/graphql-starter-kit

Bug with emails that have "." in them breaks username requirements

Open
#350 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
4k
Forks
552
PR merge metrics
No merged PRs in 30d

Description

Many email providers ignore "." in the email so you can login to Google provider with email such as "John.Frank.Doe@gmail.com" and username will be created as John.Frank.Doe, this breaks the "business rules" setup where username should only have one "." which is normally validated on the UI when changing username. If you create a user with periods in their username, it breaks the profile page for such users.

Contributor guide

Open the contributing guide

Research direction

Trace how Google sign-in creates usernames and how the profile page handles usernames containing multiple periods. Confirm the applicable username business rule and reproduce the profile failure; done means period-containing usernames no longer break the profile page or violate the stated requirement.

Written by the indexing model from the issue text.

Assessment

Tech stack
graphql, react, typescript
Domain
api, authentication, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.