kriasoft / kriasoft/AngularJS-SPA-Template
Incomplete Contacts versus About
- Dominant language
- CSS
- Stars
- 103
- Forks
- 59
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
As a boilerplate example, excellent piece of work, to begin with. But it is only a beginning. I'm sure that's been reiterated ad infinitum, so to speak. I found a couple of concerns, and I wonder if you can suggest better approaches.
It seems like I needed to add `Contacts` in a couple different places in order for the wiring to even begin to operate "correctly". "Correct" in this case meaning, at minimum, no 404 errors; in practice, well that's another story beyond the scope here.
As a backdrop, it's not the SOLID-est, nor GRASP-iest, _Insert-Favorite-Architectural-Reference-Here_, etc, boilerplate code around. But it is an interesting case study. Perhaps that's also some of the Angular MVC-ness rearing its ugly head, as comingled with the ASP.NET MVC container, I don't know.
First, I needed to add a `Contacts.cshtml`. No problem. That could draw from whatever data model backs it up. Fine, great.
Then I needed to add a `ContactsCtrl` to the `controller.js`. Okay, great. It's starting to be a bit verbose in the definition, but again, fine. We're tracking, I think.
Finally, for the wiring to behave "properly", no 404, etc, I needed to connect a `contacts` state in the `app.js`. Then all was well, the Contacts page appeared.
Victory! For the moment...
In practice, I would like to keep track of modules, features, user (or group) based roles, authorization, and so on, in the back-end, and have that programmatically inform the application, views, etc. From reading and some experience, that seems like how it's done in production quality code. Apart from special cases, Angular controllers, services, etc, to special FE business logic, I'd like for that to be more than less server-oriented, data-driven, if you will.
Interested in whatever feedback you can provide concerning this.
Contributor guide
No contributing guide indexed for this repository
Research direction
Start by reviewing the mentioned Contacts.cshtml, controller.js, and app.js files to trace the Contacts page wiring and the source of the 404s. The issue also proposes backend-driven modules, roles, and authorization, but gives no concrete scope or acceptance criteria; those would need agreement before completion can be defined.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- angularjs, bootstrap, javascript
- Domain
- authorization, full-stack
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 20/100