krfong916 / krfong916/bottomline
Entire state object passed instead of piece of state
Open
:bug: bug
- Dominant language
- JavaScript
- Stars
- 0
- Forks
- 0
- PR merge metrics
- No merged PRs in 30d
Description
https://github.com/krfong916/bottomline/blob/c7fab0879d2474200ec821d43f5785711aa5e854/proof-of-concepts/features/stories/combobox/hooks/combobox/utils.ts#L173
Observed: onStateChange handlers receive the entire object
Expected: we should only pass the smallest piece of state - the state that changed
Solution: Change object. We also haven't written tests! We need to to fix this issue!
Contributor guide
No contributing guide indexed for this repository
Assessment
This issue has not been assessed yet.