kragniz / kragniz/python-pixiv

Fix test breakage when testing saving a work

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug testing
Dominant language
Python
Stars
14
Forks
5
PR merge metrics
No merged PRs in 30d

Description

35386d0c6b3c15b701198f7ff177e09943f28bbc introduced new test coverage of downloading and saving an image from the api. This appears to break betamax on py3. Investigate and fix this.

Error here: https://travis-ci.org/kragniz/python-pixiv/jobs/101219344#L296-L302
This may be a betamax bug.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the failing Travis CI job at the linked error location and inspect the tests added by commit 35386d0c6b3c15b701198f7ff177e09943f28bbc for downloading and saving an image through the API. Investigate the Python 3 Betamax failure; done means the tests run successfully without the reported breakage.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
testing
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.