kragniz / kragniz/python-etcd3

Add support for https endpoints

Open
#340 6 comments 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
450
Forks
194
PR merge metrics
No merged PRs in 30d

Description

https://github.com/kragniz/python-etcd3/blob/master/etcd3/client.py#L108

As of right now if no certs are provided it's assumed it's an insecure connection. We should be setting the default grpc channel credentials in the event https is present without certs.

Example:
https://github.com/davissp14/etcdv3-ruby/blob/master/lib/etcdv3/connection.rb#L41-L47

Contributor guide

Open the contributing guide

Research direction

Start in etcd3/client.py around line 108 and compare the connection behavior with the linked etcdv3-ruby example. Check how an https endpoint is handled when no certificates are supplied, then verify that the default gRPC channel credentials are used in that case.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, security
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.