kowainik / kowainik/type-errors-pretty

Too strict version requirements for ghc9.2.1

Open
#24 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
56
Forks
8
PR merge metrics
No merged PRs in 30d

Description

Tried building souffle-haskell with ghc9.2.1, which depends on this package.
Got this error:

Setup: Encountered missing or private dependencies:
base >=4.10.1.0 && <4.16

Looking at https://wiki.haskell.org/Base_package, ghc9.2.1 uses base 4.16.
Tried relaxing the constraints with doJailbreak in nix, but looks like things actually changed in base:

running tests
Running 1 test suites...
Test suite doctest: RUNNING...

src/Type/Errors/Pretty.hs:114:21: error:
    • Expected kind ‘k’, but ‘t :: Symbol’ has kind ‘Symbol’
    • In the first argument of ‘ToErrorMessage’, namely ‘(t :: Symbol)’
      In the type family declaration for ‘ToErrorMessage’
src/Type/Errors/Pretty.hs:82: failure in expression `:kind! "Integer values have type: " <> Int'
expected: "Integer values have type: " <> Int :: ErrorMessage
          = 'Text "Integer values have type: " ':<>: 'ShowType Int
 but got: 
          ^
          <interactive>:1:30: error:
              Not in scope: type constructor or class ‘<>’

src/Type/Errors/Pretty.hs:98: failure in expression `:kind! "Expecting value of type: " % "   " <> Integer'
expected: "Expecting value of type: " % "   " <> Integer :: ErrorMessage
          = 'Text "Expecting value of type: "
            ':$$: ('Text "   " ':<>: 'ShowType Integer)
 but got: 
          ^
          <interactive>:1:29: error:
              Not in scope: type constructor or class ‘%’
          
          <interactive>:1:37: error:
              Not in scope: type constructor or class ‘<>’

Examples: 2  Tried: 2  Errors: 0  Failures: 2

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by checking the package's base-version constraint and the affected expressions in src/Type/Errors/Pretty.hs. Run the doctest suite with GHC 9.2.1 to reproduce the dependency and compatibility failures; done means the package supports base 4.16 while its existing tests continue to pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
haskell
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.