kovidgoyal / kovidgoyal/html5-parser
setup.py assumes MSVC on Windows
- Dominant language
- C
- Stars
- 705
- Forks
- 39
- PR merge metrics
- No merged PRs in 30d
Description
We'd like to use MinGW on Windows to compile this library, though line 22 is appending "/O2" explicitly:
```python
cargs = ('/O2' if iswindows else '-O3').split()
```
There should probably be something in place to detect if someone is using Microsoft's Compiler or Clang or GCC
Contributor guide
No contributing guide indexed for this repository
Research direction
Start in setup.py at line 22, where the Windows compiler flags are selected. Check how the build currently identifies the compiler and determine how MinGW, Microsoft's compiler, and Clang should be distinguished. Done means the library can compile on Windows with MinGW without using the MSVC-specific /O2 flag.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- c, python
- Domain
- build-system
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100