kottans / kottans/framework-2021

dev env: Change app deployment script to use gh-pages

Open
#37 1 comment 1 reaction 1 assignee Claimed by @OleksiyRudenko View on GitHub
bug
Dominant language
JavaScript
Stars
28
Forks
9
PR merge metrics
No merged PRs in 30d

Description

## Issue 1
**Problem:**
https://github.com/kottans/framework-2021/commit/a8e06addcc7adc7a079edf5006185e5ac7333ffa (currently on dev) brings back `push-dir` as a publishing script.
Alternative deployment package `gh-pages` is already listed among dev dependencies.

**Desired outcome:**
`gh-pages` is used as a publishing method.

**Suggested approach:**
`package.json`: change `deploy` script so that it runs `gh-pages -d dist`

## Issue 2

**Problem:**
https://github.com/kottans/framework-2021/commit/a8e06addcc7adc7a079edf5006185e5ac7333ffa (currently on dev) brings back shell interpretation of glob passed to `npx prettier`.

**Desired outcome:**
`npx prettier` glob is quoted and therefore interpreted by prettier, not shell.

**Suggested approach:**
`package.json`: change `prettify` script so that it runs `npx prettier --write \"**/*.{js,css,md,html}\"`

Contributor guide

No contributing guide indexed for this repository

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.