korlibs / korlibs/korge

Have virtualSize default to windowSize when not specified

Open
#913 2 comments 0 reactions 0 assignees View on GitHub
bug feature request
Dominant language
Kotlin
Stars
3k
Forks
148
Avg merge
13h 44m
Merged PRs (30d)
1

Description

I'm new to Korge, and I found a really confusing feature yesterday. I had a 1920x1080 screen (that I specified with `windowSize`), but when I drew a 1000x700 rectangle it almost covered the whole screen. I later realized that I also had to specify a `virtualSize`. I propose that, when `virtualSize` is not specified within the `Korge()` function, the `Korge.Config` dataclass, or the `Module`, it should default to the `windowSize`.

Contributor guide

No contributing guide indexed for this repository

Research direction

Locate the Korge() entry point, Korge.Config dataclass, and Module definitions mentioned in the issue, then trace how windowSize and an omitted virtualSize are handled. Confirm the default is consistent across all three paths and add regression coverage showing that virtualSize inherits windowSize when unspecified.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
game-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.