korlibs / korlibs/korge

Kproject regression in 5.4.0

Open
#2,223 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Kotlin
Stars
3k
Forks
148
Avg merge
13h 44m
Merged PRs (30d)
1

Description

### Discussed in https://github.com/korlibs/korge/discussions/2214

Originally posted by **meoowe** April 5, 2024
I saw that v5.4.0 was the newest, so I changed the second line of my libs.versions.toml from` korge = { id = "com.soywiz.korge", version = "5.3.2" }` to `korge = { id = "com.soywiz.korge", version = "5.4.0" }`. When I tried to sync, I got an error in settings.gradle.kts saying failed to apply plugin 'com.soywiz.korge.settings'. Did I miss something else I needed to change?

> I had the same issue.
>
> The actual problem however was not being unable to apply the plugin:
>
> `Failed to apply plugin 'com.soywiz.korge.settings'.
>
> > Can't find ref '#a54e3b2cacf24e0a0eb87e2580f69f8c81d083ce#v0.0.5' in Repository[/Users/daniel/.kproject/clones/github.com/korlibs/korge-tiled/**git**/.git]`
>
> The problem for me was that `deps.kproject.yml` contained a hash as part of the versioning for some dependencies. This hash doesn't break in 5.3.x but breaks in 5.4.0
>
> So instead of (example for Tiled dependency): `- https://github.com/korlibs/korge-tiled/tree/v0.0.5/korge-tiled##a54e3b2cacf24e0a0eb87e2580f69f8c81d083ce` I changed it to `- https://github.com/korlibs/korge-tiled/tree/v0.0.5/korge-tiled`

> @soywiz I had the same issue.
>
> The actual problem however was not being unable to apply the plugin:
>
> `Failed to apply plugin 'com.soywiz.korge.settings'.
>
> > Can't find ref '#a54e3b2cacf24e0a0eb87e2580f69f8c81d083ce#v0.0.5' in Repository[/Users/daniel/.kproject/clones/github.com/korlibs/korge-tiled/**git**/.git]`
>
> The problem for me was that `deps.kproject.yml` contained a hash as part of the versioning for some dependencies. This hash doesn't break in 5.3.x but breaks in 5.4.0
>
> So instead of (example for Tiled dependency): `- https://github.com/korlibs/korge-tiled/tree/v0.0.5/korge-tiled##a54e3b2cacf24e0a0eb87e2580f69f8c81d083ce` I changed it to `- https://github.com/korlibs/korge-tiled/tree/v0.0.5/korge-tiled`

## Relevant discussions

* https://github.com/korlibs/korge/discussions/2214#discussioncomment-9164858
* https://discord.com/channels/728582275884908604/801658049244430377/1232013400763138078

Contributor guide

No contributing guide indexed for this repository

Research direction

Start with settings.gradle.kts and deps.kproject.yml, comparing dependency entries that include a version hash. Reproduce the Gradle sync after changing Korge from 5.3.2 to 5.4.0, using the reported kproject error as the initial symptom. Done means dependencies containing the hash resolve successfully under 5.4.0.

Written by the indexing model from the issue text.

Assessment

Tech stack
kotlin
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.