konveyor / konveyor/rulesets

Bug: False positives for File system - Java IO

Open
#73 4 comments 0 reactions 0 assignees View on GitHub
kind/bug priority/backlog stale triage/needs-information
Dominant language
Java
Stars
6
Forks
49
PR merge metrics
No merged PRs in 30d

Description

As [discussed via Slack](https://kubernetes.slack.com/archives/C04QZJFQ0UA/p1715179784991079), the [Windup Rule _cloud-readiness/70-local-storage_](https://github.com/konveyor/rulesets/blob/main/default/generated/cloud-readiness/70-local-storage.windup.yaml) falsely matches several times in https://github.com/konveyor-demos/spring-petclinic/tree/wip/kantra.

To reproduce follow the following recipe:

1. Clone the repository
2. Check out branch `wip/kantra`
3. (Optional) Get Kantra v0.3.2 by executing the `get-kantra` script
4. Execute an analysis by executing Kantra with the `run-kantra` script (you may add more parameters, e.g., `--log-level 10`).
5. Perhaps you need to set some environment variables (take a look into the scripts):
a. Set `PODMAN_BIN=podman` if you happen to make use of podman instead of docker
b. Set `KANTRA=…` to the (full) path of your Kantra executable if you have a respective Kantra binary somewhere around (then you could skip step 3).

Look into the report with the _File System - Java IO_ issues:

![image](https://github.com/konveyor/rulesets/assets/456000/9dd1e940-a3b0-4d1e-a4b5-d8cf9810e47f)

Contributor guide

Open the contributing guide

Research direction

Reproduce the report in konveyor-demos/spring-petclinic on branch wip/kantra using the get-kantra and run-kantra scripts, then inspect the generated cloud-readiness/70-local-storage.windup.yaml rule and its File System - Java IO findings. Compare the reported matches with the application code; done means the rule no longer reports the identified false positives.

Written by the indexing model from the issue text.

Assessment

Tech stack
java
Domain
devtools
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.