konveyor / konveyor/ci

Inconsistent minikube action references between global-ci.yml and global-ci-bundle.yml

Open
#136 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Shell
Stars
0
Forks
17
Avg merge
4h 26m
Merged PRs (30d)
10

Description

## Description
The two reusable workflows use different approaches for referencing the minikube setup action, potentially causing test environment inconsistencies.

## Locations
- `.github/workflows/global-ci.yml`
- `.github/workflows/global-ci-bundle.yml`

## Details

### global-ci.yml (version-specific approach)
Uses different action branches based on operator version:
- Line 203: `v0.7.*` → `konveyor/tackle2-operator/.github/actions/start-minikube@release-0.7`
- Line 209: `v0.8.*` → `konveyor/tackle2-operator/.github/actions/start-minikube@release-0.8`
- Line 215: `latest` → `konveyor/tackle2-operator/.github/actions/start-minikube@main`

### global-ci-bundle.yml (always @main)
- Line 304: Always uses `konveyor/tackle2-operator/.github/actions/start-minikube@main`

## Impact
- Different minikube configurations may be used between the two workflows
- Tests run via `global-ci.yml` with older operator versions get version-appropriate minikube setup
- Tests run via `global-ci-bundle.yml` always get the latest minikube setup, regardless of which operator version is being tested
- Could cause test inconsistencies or unexpected failures when testing older releases with newer minikube configs

## Questions
1. Why doesn't `global-ci-bundle.yml` need version-specific minikube setup?
2. Is the bundle workflow only intended for latest/main testing?
3. Should both workflows use the same versioning strategy?

## Recommendation
Either:
1. Document why bundle workflow doesn't need version-specific minikube (if intentional)
2. Add version-specific minikube logic to `global-ci-bundle.yml` to match `global-ci.yml`
3. If bundle workflow is only for latest, document this limitation

## Related Files
- `.github/workflows/global-ci.yml:203-219`
- `.github/workflows/global-ci-bundle.yml:304-307`

Contributor guide

No contributing guide indexed for this repository

Research direction

Compare the minikube action references at lines 203-219 of .github/workflows/global-ci.yml with lines 304-307 of .github/workflows/global-ci-bundle.yml. First determine whether the bundle workflow is intended only for latest/main testing; completion requires either documenting that rationale or applying a consistent versioning strategy and validating both workflow definitions.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions
Domain
ci-cd
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.