konsumer / konsumer/rawproto

invalid .proto generation

Open
#27 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

generation-proto
Dominant language
JavaScript
Stars
61
Forks
12
PR merge metrics
No merged PRs in 30d

Description

this code uses an invalid id for fields thus resulting in an invalid .proto .schema

https://github.com/konsumer/rawproto/blob/795b15f3cc16b708570a6f5667da209ba0aee94a/src/index.js#L492

it should be something like this


for (const [fn, f] of Object.entries(tree.sub || {}))

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/index.js around line 492 and inspect how field identifiers are generated while iterating over tree.sub. Compare the current iteration with the issue's suggested Object.entries form, then verify that the generated output is a valid .proto schema.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.