kokkos / kokkos/stdBLAS

where is this `LINALG_ENABLE_KOKKOS_DEFAULT` set?

Open
#99 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
167
Forks
31
PR merge metrics
No merged PRs in 30d

Description

@crtrott @mhoemmen

I was trying to build using Kokkos, using this cmake line:
when I configure, I use:

    cmake \
	-Dmdspan_DIR=${MDSPAN_PFX}/lib/cmake/mdspan \
	-DLINALG_ENABLE_TESTS=On \
	-DLINALG_ENABLE_EXAMPLES=On \
	-DCMAKE_BUILD_TYPE="${btype}" \
	\
	-DLINALG_ENABLE_KOKKOS=On \
	-DKokkos_DIR=${KOKKOS_DIR} \
	-DKokkosKernels_DIR=${KOKKOS_KER_DIR} \
	\
	-DCMAKE_VERBOSE_MAKEFILE=On \
	-DCMAKE_INSTALL_PREFIX=../stdblas-install \
	-DGTEST_ROOT=../install_gtest \
	../stdBLAS/

But that causes a problem, because in this file: linalg_execpolicy_mapper.hpp we have:

#if defined(LINALG_ENABLE_KOKKOS) && defined(LINALG_ENABLE_KOKKOS_DEFAULT)
#include <experimental/__p1673_bits/kokkos-kernels/exec_policy_wrapper_kk.hpp>
#endif

and since LINALG_ENABLE_KOKKOS_DEFAULT is NOT set at all, I get a compile error because that header is not included.
If I change that to || it works.

But was wondering: what is the role of LINALG_ENABLE_KOKKOS_DEFAULT? Is that supposed to be set by user? Or what?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting linalg_execpolicy_mapper.hpp and the CMake configuration used in the report to trace whether LINALG_ENABLE_KOKKOS_DEFAULT is defined or propagated. Reproduce the reported Kokkos configuration and compile failure, then document or correct the expected macro behavior so the Kokkos build completes without changing the condition ad hoc.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.