vector_sum_of_squares: Add implementation for non-floating-point types
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 167
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
The current implementation depends on being able to convert 1.0 to Scalar.
We might also want to consider adding a Note to P1673 that the preferred initial value for the init argument's "scaled sum of squares" field is 1 (or whatever that means for your Scalar type).
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the vector_sum_of_squares implementation and inspect how it converts 1.0 to Scalar. Check the surrounding P1673 guidance for the init argument; done means non-floating-point Scalar types are supported and the preferred initial value is documented if that note is in scope.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- hpc
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100