kokkos / kokkos/stdBLAS

Add tropical algebra tests

Open
#329 0 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
167
Forks
31
PR merge metrics
No merged PRs in 30d

Description

As discussed with @mhoemmen. These tests will expose whether we've accidentally made invalid assumptions about datatypes in the code, like assuming a value can be initialized to 0.

Yes, technically Tropical t = 0 makes mathematical sense, but I'll be sure not to define Tropical::operator=(int) or Tropical::Tropical(int).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the tropical algebra implementation and the existing test suite in stdBLAS. Read the Tropical type and its current initialization and assignment behavior, then add tests that expose invalid datatype assumptions, including the stated distinction around initializing from 0. Done means the tests reliably detect those assumptions without requiring Tropical integer construction or assignment.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
testing
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.