Rank-k and Rank-2k preconditions are wrong and other problems
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 167
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
Preconditions rank-k updates written in the proposal document are wrong as A must NOT be a square matrix:
https://eel.is/c++draft/linalg#algs.blas3.rankk-3.2
https://eel.is/c++draft/linalg#algs.blas3.rankk-4.1
Similarly, preconditions of rank-2k are wrong.
https://eel.is/c++draft/linalg#algs.blas3.rank2k-4.1 and https://eel.is/c++draft/linalg#algs.blas3.rank2k-4.1 should read multipliable instead of addable,
https://eel.is/c++draft/linalg#algs.blas3.rank2k-3.3 and https://eel.is/c++draft/linalg#algs.blas3.rank2k-4.2
C should be the square matrix, not A.
Which is the correct way to ask for fixing those?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading the linked eel.is sections for rank-k and rank-2k preconditions and compare the stated matrix-shape and addable/multipliable requirements. Confirm the intended corrections against the proposal document and repository contribution process; done means the affected preconditions are corrected and the updated wording is reviewed.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- documentation
- Issue type
- Documentation
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100