kokkos / kokkos/stdBLAS

Make sure `_blas2_signed_fixture` is not globally visible

Open
#199 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
167
Forks
31
PR merge metrics
No merged PRs in 30d

Description

Certainly a good improvement. But where is this _blas2_signed_fixture thing coming from? Is that some semi pulic non-namespaced thing in our headers?

Originally posted by @crtrott in https://github.com/kokkos/stdBLAS/pull/187#pullrequestreview-952517072

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating _blas2_signed_fixture in the repository and inspect its declaration, definition, and any headers that expose it. Confirm which scope it currently has and identify the smallest change that prevents global visibility; done means the fixture is no longer exposed globally without breaking its existing uses.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
backend-api-design
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.