`vector_sum_of_squares` should only rescale for floating-point types, and should not use Scalar(1.0) or Scalar(0.0) otherwise
Open
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 167
- Forks
- 31
- PR merge metrics
- No merged PRs in 30d
Description
vector_sum_of_squares has the following issues:
- It does rescaling for all types, not just floating-point types (and complex-of-floating-point types).
- It attempts to construct
Scalar(1.0)andScalar(0.0)for all types.
See discussion here.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the vector_sum_of_squares implementation and reviewing the linked discussion in issue 141. Check how rescaling and Scalar(1.0)/Scalar(0.0) construction are selected across scalar types; done means floating-point and complex-of-floating-point types retain the intended behavior while other types avoid both operations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- data
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100