kokkos / kokkos/mdspan

C++14 requirement mismatch between README and source code

Open
#313 14 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
507
Forks
87
Avg merge
15h 27m
Merged PRs (30d)
2

Description

README says:
C++14 backport (e.g., fold expressions not required)

but I noticed use of fold expressions here:
https://github.com/kokkos/mdspan/blob/fef0c8a40e4bd6111eeee36416593504f50cadf3/include/experimental/__p0009_bits/extents.hpp#L61-L63

there may be more (I haven't checked).

Should the use of fold expressions be removed? Or will C++14 support require some C++17 language features?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the C++14 claim in README with the fold-expression use in include/experimental/__p0009_bits/extents.hpp at lines 61–63. Search for other C++17 language features, then establish whether the documentation or source is authoritative; done means the stated requirement and implementation agree and the relevant checks pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
compilers
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.