kokkos / kokkos/mdspan

Godbolt example broken

Open
#259 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
507
Forks
87
Avg merge
15h 27m
Merged PRs (30d)
2

Description

It looks like the latest commit to the single-header branch broke things. There are a bunch of errors regarding redefinitions (one example is below):

In file included from <source>:11:
/app/raw.githubusercontent.com/kokkos/mdspan/single-header/mdspan.hpp:1111:8: error: redefinition of 'struct std::default_accessor<ElementType>'
 1111 | struct default_accessor {
      |        ^~~~~~~~~~~~~~~~
/app/raw.githubusercontent.com/kokkos/mdspan/single-header/mdspan.hpp:1011:8: note: previous definition of 'struct std::default_accessor<ElementType>'
 1011 | struct default_accessor {
      |        ^~~~~~~~~~~~~~~~

I went back to the previous commit and it worked fine (https://raw.githubusercontent.com/kokkos/mdspan/15563ed9ab955f8a2e555181a71583a9913816c2/mdspan.hpp instead of https://raw.githubusercontent.com/kokkos/mdspan/single-header/mdspan.hpp).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Compare the current single-header/mdspan.hpp with the working file from commit 15563ed9ab955f8a2e555181a71583a9913816c2 and reproduce the failure in the reported Godbolt example. Inspect the duplicate std::default_accessor definitions and verify that the single-header version compiles without redefinition errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
build-system
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.