kokkos / kokkos/kokkos-tutorials

`numberOfTeams` in TeamPolicy related slides

Open
#23 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
C++
Stars
388
Forks
129
PR merge metrics
No merged PRs in 30d

Description

In the slides to the current tutorials (e.g., https://github.com/kokkos/kokkos-tutorials/blob/master/Intro-Full/Slides/KokkosTutorial_PACT19.pdf, p. 101ff)
the constructor to TeamPolicy is described as:

TeamPolicy < ExecutionSpace >( numberOfTeams , teamSize )

while on the official kokkos wiki the constructor looks like the following (https://github.com/kokkos/kokkos/wiki/Kokkos::TeamPolicy):

Kokkos::TeamPolicy<>( league_size, team_size [, vector_length])

In my opinion the name numberOfTeams is very misleading, as it appears to be dependent on the teamSize, which it is not. It should be renamed to league_size.

The calculation of work on page 101 might also need an update.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the Intro-Full KokkosTutorial_PACT19.pdf slides linked in the issue, focusing on page 101 and the following pages, then compare the TeamPolicy terminology with the linked Kokkos wiki page. Update the numberOfTeams wording to match league_size and verify whether the page 101 work calculation also needs revision.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp
Domain
documentation
Issue type
Documentation
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.