kokke / kokke/tiny-AES-c

#define AES_KEYLEN bites with SAMD5 compiler

Open
#125 4 comments 0 reactions 0 assignees View on GitHub
Dominant language
C
Stars
5k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

Hi,

your tiny AES works flawlessly on an Arduino Feather M4 Express (AVR SAMD5 architecture).
But the #define AES_KEYLEN get's redefined in the include files from the compiler. The SAMD5 has a hardware AES module and defines it's own AES_KEYLEN.

So maybe rename some things in this library?

BR

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by inspecting the library's include files and every use of AES_KEYLEN, then compare them with the SAMD5 compiler definitions. Rename the colliding library symbols consistently and verify that AES-128/192/256 builds and existing tests still work without redefinition warnings.

Written by the indexing model from the issue text.

Assessment

Tech stack
c
Domain
cryptography
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.