kohya-ss / kohya-ss/sd-scripts

Whether parse_args shoulde be replaced by parse_known_args?

Open
#506 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Python
Stars
7.2k
Forks
1.2k
Avg merge
11m
Merged PRs (30d)
2

Description

For now, cli throws an exception `unrecognized arguments` if some redundant parameters was provided. Most of the parameters are common of different training ways.

Contributor guide

No contributing guide indexed for this repository

Research direction

Start by locating the CLI entry points that call parse_args and review how arguments are defined for the different training paths. Compare the current behavior with parse_known_args using the redundant common-parameter case described in the issue, and verify that the intended training arguments still work without an unrecognized-arguments exception.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
cli
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.