kohya-ss / kohya-ss/sd-scripts

Hardcoded bucket_step overrides configurable parameter

Open
#1,915 4 comments 0 reactions 0 assignees View on GitHub
bug
Dominant language
Python
Stars
7.2k
Forks
1.2k
Avg merge
11m
Merged PRs (30d)
2

Description

Hey, just noticed that bucket_step is hardcoded to 64 here:
https://github.com/kohya-ss/sd-scripts/blob/0778dd9b1df0d6aa33287ded3ce4195f3d03251b/train_network.py#L127-L130
But there's already a configurable parameter for this elsewhere in the code. This kinda defeats the purpose of having it configurable in the first place.

Personally, I find 32 way more practical than 64. Any particular reason for this change? Any chance we can bring back configurability?

Contributor guide

No contributing guide indexed for this repository

Research direction

Start in train_network.py around lines 127–130 and trace the existing configurable bucket_step parameter elsewhere in the code. Confirm where the hardcoded value overrides it, then verify that the configured value is honored, including values such as 32.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
58/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.