kohya-ss / kohya-ss/ControlNet-LLLite-ComfyUI

parameters doesn't get applied to controlnet

Open
#4 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
Python
Stars
225
Forks
17
PR merge metrics
No merged PRs in 30d

Description

Thank you for sharing this node for ComfyUI.

![image](https://github.com/kohya-ss/ControlNet-LLLite-ComfyUI/assets/26363920/8ad2d4f8-ae3a-4752-a896-a63144576bee)

I encountered an error while using [qr-pattern-sdxl-ControlNet-LLLite](https://huggingface.co/Nacholmo/qr-pattern-sdxl-ControlNet-LLLite). When start and end are set to parameters other than 0.0, the controlnet is not applied. Additionally, it does not allow entering 2 decimal places (e.g., 0.75) and rounds to 1 decimal place.

Setting strength below 0.85 does not change the image.

workflow

workflow

```javascript
{
"last_node_id": 65,
"last_link_id": 114,
"nodes": [
{
"id": 32,
"type": "PrimitiveNode",
"pos": [
-90,
-220
],
"size": {
"0": 398,
"1": 140
},
"flags": {},
"order": 0,
"mode": 0,
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": [
51,
52
],
"widget": {
"name": "text_g"
},
"slot_index": 0
}
],
"title": "Positive Prompt",
"properties": {},
"widgets_values": [
"beautiful follower Lydia, young nordic woman in nordic armor, breath taking landscape of skyrim, mountains of high hrothgar with snow on top, green grass and road, subtle mist, nordic weather, wallpaper, intricate, 8K, concept art"
]
},
{
"id": 30,
"type": "CLIPTextEncodeSDXL",
"pos": [
407,
-219
],
"size": {
"0": 399.84454345703125,
"1": 262.6287841796875
},
"flags": {},
"order": 5,
"mode": 0,
"inputs": [
{
"name": "clip",
"type": "CLIP",
"link": 49,
"slot_index": 0
},
{
"name": "text_g",
"type": "STRING",
"link": 51,
"widget": {
"name": "text_g"
}
},
{
"name": "text_l",
"type": "STRING",
"link": 52,
"widget": {
"name": "text_l"
}
}
],
"outputs": [
{
"name": "CONDITIONING",
"type": "CONDITIONING",
"links": [
111
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "CLIPTextEncodeSDXL"
},
"widgets_values": [
1024,
1024,
0,
0,
1024,
1024,
"beautiful follower Lydia, young nordic woman in nordic armor, breath taking landscape of skyrim, mountains of high hrothgar with snow on top, green grass and road, subtle mist, nordic weather, wallpaper, intricate, 8K, concept art",
"beautiful follower Lydia, young nordic woman in nordic armor, breath taking landscape of skyrim, mountains of high hrothgar with snow on top, green grass and road, subtle mist, nordic weather, wallpaper, intricate, 8K, concept art"
]
},
{
"id": 33,
"type": "CLIPTextEncodeSDXL",
"pos": [
405,
92
],
"size": {
"0": 400,
"1": 270.0000305175781
},
"flags": {},
"order": 6,
"mode": 0,
"inputs": [
{
"name": "clip",
"type": "CLIP",
"link": 54,
"slot_index": 0
},
{
"name": "text_g",
"type": "STRING",
"link": 55,
"widget": {
"name": "text_g"
}
},
{
"name": "text_l",
"type": "STRING",
"link": 57,
"widget": {
"name": "text_l"
},
"slot_index": 2
}
],
"outputs": [
{
"name": "CONDITIONING",
"type": "CONDITIONING",
"links": [
112
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "CLIPTextEncodeSDXL"
},
"widgets_values": [
1024,
1024,
0,
0,
1024,
1024,
"ac_neg1, road marking",
"ac_neg1, road marking"
]
},
{
"id": 61,
"type": "ImageScale",
"pos": [
52,
510
],
"size": {
"0": 315,
"1": 130
},
"flags": {},
"order": 7,
"mode": 0,
"inputs": [
{
"name": "image",
"type": "IMAGE",
"link": 104
}
],
"outputs": [
{
"name": "IMAGE",
"type": "IMAGE",
"links": [
106
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "ImageScale"
},
"widgets_values": [
"bilinear",
1024,
1024,
"disabled"
]
},
{
"id": 16,
"type": "PrimitiveNode",
"pos": [
-90,
-40
],
"size": {
"0": 398,
"1": 140
},
"flags": {},
"order": 1,
"mode": 0,
"outputs": [
{
"name": "STRING",
"type": "STRING",
"links": [
55,
57
],
"slot_index": 0,
"widget": {
"name": "text_g"
}
}
],
"title": "Negative Prompt",
"properties": {},
"widgets_values": [
"ac_neg1, road marking"
]
},
{
"id": 4,
"type": "CheckpointLoaderSimple",
"pos": [
-663,
178
],
"size": {
"0": 397,
"1": 98
},
"flags": {},
"order": 2,
"mode": 0,
"outputs": [
{
"name": "MODEL",
"type": "MODEL",
"links": [
107
],
"slot_index": 0
},
{
"name": "CLIP",
"type": "CLIP",
"links": [
49,
54
],
"slot_index": 1
},
{
"name": "VAE",
"type": "VAE",
"links": [
46
],
"slot_index": 2
}
],
"properties": {
"Node name for S&R": "CheckpointLoaderSimple"
},
"widgets_values": [
"dreamshaperXL10_alpha2Xl10.safetensors"
]
},
{
"id": 43,
"type": "EmptyLatentImage",
"pos": [
-18,
165
],
"size": {
"0": 315,
"1": 106
},
"flags": {},
"order": 3,
"mode": 0,
"outputs": [
{
"name": "LATENT",
"type": "LATENT",
"links": [
113
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "EmptyLatentImage"
},
"widgets_values": [
1024,
1024,
4
]
},
{
"id": 26,
"type": "VAEDecode",
"pos": [
1196,
-316
],
"size": {
"0": 140,
"1": 46
},
"flags": {},
"order": 10,
"mode": 0,
"inputs": [
{
"name": "samples",
"type": "LATENT",
"link": 114,
"slot_index": 0
},
{
"name": "vae",
"type": "VAE",
"link": 46,
"slot_index": 1
}
],
"outputs": [
{
"name": "IMAGE",
"type": "IMAGE",
"links": [
109
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "VAEDecode"
}
},
{
"id": 63,
"type": "PreviewImage",
"pos": [
1167,
-216
],
"size": {
"0": 746.39990234375,
"1": 723.2000732421875
},
"flags": {},
"order": 11,
"mode": 0,
"inputs": [
{
"name": "images",
"type": "IMAGE",
"link": 109
}
],
"properties": {
"Node name for S&R": "PreviewImage"
}
},
{
"id": 64,
"type": "KSamplerAdvanced",
"pos": [
870,
-315
],
"size": {
"0": 281.6816101074219,
"1": 334
},
"flags": {},
"order": 9,
"mode": 0,
"inputs": [
{
"name": "model",
"type": "MODEL",
"link": 110
},
{
"name": "positive",
"type": "CONDITIONING",
"link": 111
},
{
"name": "negative",
"type": "CONDITIONING",
"link": 112
},
{
"name": "latent_image",
"type": "LATENT",
"link": 113
}
],
"outputs": [
{
"name": "LATENT",
"type": "LATENT",
"links": [
114
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "KSamplerAdvanced"
},
"widgets_values": [
"enable",
2137,
"fixed",
20,
5,
"dpmpp_3m_sde_gpu",
"karras",
0,
10000,
"disable"
]
},
{
"id": 62,
"type": "LLLiteLoader",
"pos": [
937,
62
],
"size": {
"0": 210,
"1": 174
},
"flags": {},
"order": 8,
"mode": 0,
"inputs": [
{
"name": "model",
"type": "MODEL",
"link": 107
},
{
"name": "cond_image",
"type": "IMAGE",
"link": 106
}
],
"outputs": [
{
"name": "MODEL",
"type": "MODEL",
"links": [
110
],
"shape": 3,
"slot_index": 0
}
],
"properties": {
"Node name for S&R": "LLLiteLoader"
},
"widgets_values": [
"controllllite_v01256512e_sdxl_qrpattern.safetensors",
2,
20,
0.1,
0.9
]
},
{
"id": 59,
"type": "LoadImage",
"pos": [
929,
279
],
"size": [
210,
314
],
"flags": {},
"order": 4,
"mode": 0,
"outputs": [
{
"name": "IMAGE",
"type": "IMAGE",
"links": [
104
],
"shape": 3,
"slot_index": 0
},
{
"name": "MASK",
"type": "MASK",
"links": null,
"shape": 3
}
],
"properties": {
"Node name for S&R": "LoadImage"
},
"widgets_values": [
"inigo (1).png",
"image"
]
}
],
"links": [
[
46,
4,
2,
26,
1,
"VAE"
],
[
49,
4,
1,
30,
0,
"CLIP"
],
[
51,
32,
0,
30,
1,
"STRING"
],
[
52,
32,
0,
30,
2,
"STRING"
],
[
54,
4,
1,
33,
0,
"CLIP"
],
[
55,
16,
0,
33,
1,
"STRING"
],
[
57,
16,
0,
33,
2,
"STRING"
],
[
104,
59,
0,
61,
0,
"IMAGE"
],
[
106,
61,
0,
62,
1,
"IMAGE"
],
[
107,
4,
0,
62,
0,
"MODEL"
],
[
109,
26,
0,
63,
0,
"IMAGE"
],
[
110,
62,
0,
64,
0,
"MODEL"
],
[
111,
30,
0,
64,
1,
"CONDITIONING"
],
[
112,
33,
0,
64,
2,
"CONDITIONING"
],
[
113,
43,
0,
64,
3,
"LATENT"
],
[
114,
64,
0,
26,
0,
"LATENT"
]
],
"groups": [],
"config": {},
"extra": {},
"version": 0.4
}
```

Contributor guide

No contributing guide indexed for this repository

Research direction

Start at the LLLiteLoader node and reproduce the workflow using qr-pattern-sdxl-ControlNet-LLLite, varying the start, end, and strength values. Check why values such as 0.75 are rounded and why settings below 0.85 do not affect the generated image; done means the parameters are applied and decimal inputs are preserved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.